Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sdc_newton_use_analytic_jac #2573

Merged
merged 25 commits into from
Sep 22, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 22, 2023

PR summary

We will rely on integrator.jacobian now

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member Author

zingale commented Sep 22, 2023

depends on #2560

@zingale zingale added the sdc label Sep 22, 2023
@zingale zingale changed the title [WIP] remove sdc_newton_use_analytic_jac remove sdc_newton_use_analytic_jac Sep 22, 2023
@zingale zingale merged commit 716dd64 into AMReX-Astro:development Sep 22, 2023
17 checks passed
@zingale zingale deleted the sdc_cleaning_VI branch September 22, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants