Bump and pin node-opcua to version 2.133.0 in acs-edge
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is merged, I don't see any blockers to merging #371 |
Zoobdude
changed the title
acs-edge
Merged
amrc-benmorrow
added a commit
that referenced
this pull request
Nov 27, 2024
|
This change is included in #380. |
|
You need to use noodeModuleResolution:"node16" in your tsconfig.json file if you want to use the latest vrsion of node-opcua. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After quite comprehensive testing, I've discovered that the issue preventing the
acs-edgefrom building is thenode-opcuapackage.This module seems to depend on node-opcua-crypto package which had a breaking change to its exports in
v4.11.0.This seems to have effected the following modules:
node-opcua-address-space-basenode-opcua-address-spacenode-opcua-certificate-managernode-opcua-clientnode-opcua-commonnode-opcua-secure-channelnode-opcua-servernode-opcua-cryptoAll of which the node-opcua package depends on.
The last working version of this package seems to be
2.133.0therefore I have pinned in to that until the upstream issue is resolved.I have created an issue on the libs repo (node-opcua/node-opcua-crypto#61) relating to this.