WIP: SHACL to Jekyll layout #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splattater
force-pushed
the
jekyll-layout
branch
from
adff475 to
eba5e17
Compare
shinobu
reviewed
Sep 11, 2018
ShacShifter/JekyllRDFSerializer.py
Outdated
| self.logger.debug(nodes) | ||
|
|
||
| for property in nodeShape.properties: | ||
| shapeName = nodeShape.targetClass[0].rsplit('/', 1)[-1] |
There was a problem hiding this comment.
Starting here, until line 88 are calls to nodeShape.targetClass without prior testing if targetClass has any entries. There should be a more viable way to get the shapeName, Especially if no targetClass exists (checkable with nodeShape.isSet[variableName] too)
There was a problem hiding this comment.
@thoffma and @white-gecko can you help @shinobu
|
@white-gecko, @thoffma the branch is working with the "new" ShacShifter base, yet. Can you check if the html output of jekyll-rdf serialization is as expected/add a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes provide a ShacShifter Serializer for writing templates for Jekyll-RDF