Skip to content

Commit

Permalink
Themes: Replace "Active" wording with "Installed" in the theme instal…
Browse files Browse the repository at this point in the history
…l checks page.

When reinstalling a theme by uploading a ZIP file, the wording used in some strings referred to the "active" theme even though it's not the currrently active theme. This changeset replaces these strings to refer to the "installed" theme, which is more accurate.

Follow-up to [52610], [52580].

Props afercia, ankitkumarshah, abcd95, yogeshbhutkar, parthvataliya, sainathpoojary, virgar, gaellebesson, nuryko, guillaumeturpin, maximemeganck, sabrineg.
Fixes #62603.
See #54831, #54770




git-svn-id: https://develop.svn.wordpress.org/trunk@59513 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
audrasjb committed Dec 13, 2024
1 parent 85937e7 commit 1cc1af2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/wp-admin/includes/class-theme-installer-skin.php
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ private function do_overwrite() {
);

$table = '<table class="update-from-upload-comparison"><tbody>';
$table .= '<tr><th></th><th>' . esc_html_x( 'Active', 'theme' ) . '</th><th>' . esc_html_x( 'Uploaded', 'theme' ) . '</th></tr>';
$table .= '<tr><th></th><th>' . esc_html_x( 'Installed', 'theme' ) . '</th><th>' . esc_html_x( 'Uploaded', 'theme' ) . '</th></tr>';

$is_same_theme = true; // Let's consider only these rows.

Expand Down Expand Up @@ -333,7 +333,7 @@ private function do_overwrite() {
if ( $this->is_downgrading ) {
$warning = sprintf(
/* translators: %s: Documentation URL. */
__( 'You are uploading an older version of the active theme. You can continue to install the older version, but be sure to <a href="%s">back up your database and files</a> first.' ),
__( 'You are uploading an older version of the installed theme. You can continue to install the older version, but be sure to <a href="%s">back up your database and files</a> first.' ),
__( 'https://developer.wordpress.org/advanced-administration/security/backup/' )
);
} else {
Expand All @@ -351,7 +351,7 @@ private function do_overwrite() {
$install_actions['overwrite_theme'] = sprintf(
'<a class="button button-primary update-from-upload-overwrite" href="%s" target="_parent">%s</a>',
wp_nonce_url( add_query_arg( 'overwrite', $overwrite, $this->url ), 'theme-upload' ),
_x( 'Replace active with uploaded', 'theme' )
_x( 'Replace installed with uploaded', 'theme' )
);
} else {
echo $blocked_message;
Expand Down

0 comments on commit 1cc1af2

Please sign in to comment.