Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.3 (bugfixes, primarily) #256

Merged
merged 6 commits into from
Mar 21, 2024
Merged

v1.2.3 (bugfixes, primarily) #256

merged 6 commits into from
Mar 21, 2024

Conversation

matthewcarbone
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 47.37%. Comparing base (a5ad373) to head (b34a23b).

Files Patch % Lines
lightshow/_version.py 75.00% 2 Missing ⚠️
lightshow/parameters/vasp.py 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   47.19%   47.37%   +0.17%     
==========================================
  Files          15       16       +1     
  Lines        1267     1277      +10     
==========================================
+ Hits          598      605       +7     
- Misses        669      672       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewcarbone matthewcarbone merged commit 82fdb21 into master Mar 21, 2024
11 checks passed
@matthewcarbone matthewcarbone deleted the mc/v1.2.3 branch March 21, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix local versioning issues Single absorbing atom leads to ghost atom in POSCAR
2 participants