Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding back building images with mode=stable #1173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding back building images with mode=stable #1173

wants to merge 1 commit into from

Conversation

parambole
Copy link
Collaborator

Description

The flow to build maxtext with mode=stable was removed. This PR adds it back.

Tests

Ran the command locally

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@parambole parambole requested a review from yangyuwei January 16, 2025 23:55
@parambole parambole mentioned this pull request Jan 17, 2025
Open
4 tasks
yangyuwei
yangyuwei approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@yangyuwei yangyuwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Param for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangyuwei yangyuwei yangyuwei approved these changes

@gobbleturk gobbleturk gobbleturk approved these changes

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parambole @gobbleturk @yangyuwei