Add option to skip initializing the jax distributed system #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobbleturk
requested review from
khatwanimohit,
bvandermoon,
vipannalla and
RissyRan
as code owners
RissyRan
reviewed
Dec 24, 2024
| @@ -219,6 +219,9 @@ def maybe_initialize_jax_distributed_system(raw_keys): | |||
|
|
|||
| For CPUs, we call jax.distributed.initialize() explicitly, with the specified arguments. | |||
| """ | |||
| if raw_keys["skip_jax_distributed_system"]: | |||
There was a problem hiding this comment.
Nit: Thanks for the log! So we know the reason to skip the initialization. Could you help add accordingly logs to following 2 cases? inference_benchmark_test & compile_topology?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option to skip jax.distributed.initialize() explicitly.
This is necessary for internal runs with checkpointing, where the jax distributed system is initialized for us and should not be initialized explicitly
Tests
Ran with this new flag both true and false, saw expected results.
Checklist
Before submitting this PR, please make sure (put X in square brackets):