Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all tests to pass locally with no special configuration #1108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamuelMarks
Copy link

@SamuelMarks SamuelMarks commented Dec 19, 2024

Description

FIXES: #1107

Tests

python -m pytest and pytest should both now work when run from repository root.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Important: do not merge yet! - I want to solve your grain issue [ https://github.com/AI-Hypercomputer/maxtext/actions/runs/12421511705/job/34681866302 ] first; which I think this commit fixed google/grain@ce66a97...08f7cb1
EDIT: Can you ping the guys? - Looks like they just need to release anew google/grain/issues/662

@shralex
Copy link
Collaborator

shralex commented Dec 20, 2024

The grain issue might be solved by #1109

@SamuelMarks
Copy link
Author

Good to see. Also related is your recent PR #1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

26 Errors on (local) unittest running
2 participants