Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in trillium llama2-70b script #1105

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Fix typo in trillium llama2-70b script #1105

wants to merge 24 commits into from
+153 −37

Conversation

wenxindongwork
Copy link
Collaborator

@wenxindongwork wenxindongwork commented Dec 19, 2024 •
edited
Loading

Description

Fix typo in Trillium llama2-70b script. Changed 70b to 7b.

Tests

This script is used for regression testing in XLML.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@wenxindongwork
fix typo
0f2ace2 
Update 70b to 7b
maxtext authors and others added 22 commits December 19, 2024 14:24
Merge pull request #1103 from AI-Hypercomputer:fix_gmm_acc_dtype
6c767f4 
PiperOrigin-RevId: 708032400
@ZhiyuLi-goog
Fix lib version mismatch between orbax and grain
a4fa960
Merge pull request #1109 from AI-Hypercomputer:lizhiyu/fix_orbax_version
6819d47 
PiperOrigin-RevId: 708109054
@raymondzouu
Add Llama 3.1 with 8192 seq len Trillium config
b07e906
@gobbleturk
Add ran as maxtext reviewer
01c6132
Merge pull request #1116 from AI-Hypercomputer:mattdavidow-ran-owner
834b778 
PiperOrigin-RevId: 708475466
@fenghuizhang
Add options to reduce manual work in e2e JetStream benchmark tests.
1df6662
Merge pull request #1102 from AI-Hypercomputer:fhzhang/rampup
6ec3368 
PiperOrigin-RevId: 708497751
@tornikeo
Recommend using v5e instead of v4
5b22180
@tornikeo
Update First_run.md
0075318
@gobbleturk
Fix typo in custom remat config comments
5dd56b6
@RissyRan
Update type casting for activation
b433027
Merge pull request #1111 from AI-Hypercomputer:fix_activation_type
3f3340c 
PiperOrigin-RevId: 709099080
Merge pull request #1114 from AI-Hypercomputer:raymondzou-llama31-8192
6135303 
PiperOrigin-RevId: 709106705
Merge pull request #1118 from tornikeo:patch-1
07788af 
PiperOrigin-RevId: 709126745
Merge pull request #1120 from AI-Hypercomputer:mattdavidow-fix-remat-…
337cb69 
…typo

PiperOrigin-RevId: 709126885
@hengtaoguo
Print memory stats after start_step
3eb7d47 
Update the label for print_mem_stats during params intialization

Remove accidentally added xpk
@wang2yn84
Bumps up Transformer Engine to 1.13 from 1.5.
0299f7a
Merge pull request #1110 from AI-Hypercomputer:hengtaoguo-ckpt
087f746 
PiperOrigin-RevId: 709155128
Merge pull request #1124 from AI-Hypercomputer:lance-bumpup-te
77f6459 
PiperOrigin-RevId: 709158692
@wenxindongwork
fix typo
671fcb0 
Update 70b to 7b
@wenxindongwork
Merge branch 'wenxindong-fix-typo' of https://github.com/AI-Hypercomp…
cd2f769 
…uter/maxtext into wenxindong-fix-typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khatwanimohit khatwanimohit khatwanimohit approved these changes

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.