Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gazebo Tutorial and partial Oops assignment added. #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shivamvats
Copy link
Member

No description provided.

@dragonfly91
Copy link
Contributor

@shivamvats Is this the complete commit? I don't see some auxiliary files (CMakeLists.txt and manifest.xml). Are they not required? Also, if this is a package, it would be nice to see some structure (source files under 'src', includes under 'include', configuration files under 'config' etc). Other than that, nice work! 👍

@hargup
Copy link
Member

hargup commented Mar 14, 2014

@shivamvats why are there two folders Oops and Oops1? Remove the unnecessary folder.

@hargup
Copy link
Member

hargup commented Mar 14, 2014

@shivamvats there is no CMakeLists.txt or Makefile in your project. How are you compiling your code?

#include <opencv/highgui.h>
#include <opencv2/imgproc/imgproc.hpp>
#include "queue.h"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have not included Oops_class.h in this file.

@shivamvats
Copy link
Member Author

How do I delete commited files? Should I add the folder after deleting it or should I rm the folder?

@NightFury37
Copy link

Delete the files and commit (you have to commit that you have deleted)

On Sat, Mar 15, 2014 at 7:43 AM, shivamvats [email protected]:

How do I delete commited files? Should I add the folder after deleting it
or should I rm the folder?

Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-37713656
.

#ifndef queue_h
#define queue_h
#include <iostream>
#include "queue.cpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line.

The reason you are getting error like
queue.cpp:11:6: error: ‘queue’ has not been declared are because you include queue.h in queue.cpp and in queue.cpp you have included queue.h. This lead to circular dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing I was able to at least compile your code.
Good Job 👍

@hargup
Copy link
Member

hargup commented Mar 15, 2014

Add the image you used for testing. And avoid hardcoding the locations of files in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants