Basic nvrhi renderer #113
Merged
Basic nvrhi renderer #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # include/math/Math.h # src/Engine.cpp
# Conflicts: # src/Engine.cpp
# Conflicts: # archimedes_bin/main.cpp # cmake/library.cmake # include/Engine.h # src/Engine.cpp
Chris-plusplus
requested changes
Dec 27, 2024
|
|
||
| virtual void render(const Ref<Mesh>& mesh, const Mat4x4& transform) = 0; | ||
|
|
||
| public: |
There was a problem hiding this comment.
These help divide API to logical parts.
| static Ref<Renderer> current() { return s_current; } | ||
|
|
||
| protected: | ||
| explicit Renderer(RenderingAPI api, bool debug = true): _api(api), _debug(debug) {} |
There was a problem hiding this comment.
Can be moved to 2nd protected:
There was a problem hiding this comment.
These help divide API to logical parts.
|
|
||
| void cleanup(const Ref<VulkanContext>& context); | ||
|
|
||
| public: |
There was a problem hiding this comment.
These help divide API to logical parts.
| private: | ||
| Ref<Scene> _currentScene; | ||
|
|
||
| public: |
There was a problem hiding this comment.
can be merged with 1st public:
There was a problem hiding this comment.
These help divide API to logical parts.
Chris-plusplus
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows entities to draw triangles