Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic ArchMath #100

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Add basic ArchMath #100

merged 4 commits into from
Apr 19, 2024

Conversation

Twarug
Copy link
Contributor

@Twarug Twarug commented Apr 16, 2024

No description provided.

Tosiekdev
Tosiekdev reviewed Apr 19, 2024
View reviewed changes
include/Ref.h Outdated Show resolved Hide resolved
Tosiekdev
Tosiekdev reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Tosiekdev Tosiekdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check comments not within the review. Moreover, consider using construction with brackets and not by copy constructor.

include/math/Math.h Show resolved Hide resolved
src/Transform.cpp Outdated Show resolved Hide resolved
src/Transform.cpp Outdated Show resolved Hide resolved
src/Transform.cpp Outdated Show resolved Hide resolved
Tosiekdev
Tosiekdev approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@Tosiekdev Tosiekdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@Twarug Twarug merged commit e29d1e1 into master Apr 19, 2024
1 check passed
@Twarug Twarug deleted the twarug/math branch April 19, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tosiekdev Tosiekdev Tosiekdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Twarug @Tosiekdev