-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic curvature #974
Merged
Merged
Add basic curvature #974
Changes from all commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
9be0604
Add beginnings of curvature file
SylviaWhittle 541a514
Add angle_diff_signed
SylviaWhittle 7e7cfdd
Add test_angle_diff_signed
SylviaWhittle 6569f94
Add discrete_angle_difference_per_nm_circular
SylviaWhittle 138ab89
Fix normalisation and flipped subtractions in first and last index
SylviaWhittle 7fa02ef
Add test for discrete_angle_difference_per_nm_circular
SylviaWhittle c5be319
Add find_curvature_defects_simple_threshold
SylviaWhittle bce731c
Add test for find_curvature_defects_simple_threshold
SylviaWhittle ee6c8af
Add calculate_trace_distances_to_last_points_circular
SylviaWhittle c262ad9
Add calculate_distances_between_distances_circular
SylviaWhittle 9701b20
Add test_trace_distances_to_last_points_circular
SylviaWhittle de0c0b2
Add test_calculate_distances_between_defects_circular
SylviaWhittle 6ee2bc5
Add calculate_number_of_defects
SylviaWhittle e175e87
add test_caclculate_number_of_defects
SylviaWhittle 7cc6b0b
Add calculate_curvature_stats_single_grain_circular
SylviaWhittle f4cb94c
Add calculate_curvature_stats_image
SylviaWhittle f5013f8
Add plot_curvatures
SylviaWhittle f8734cd
Add plot_curvatures_individual_grains
SylviaWhittle 39f3295
Add test_plot_curvature
SylviaWhittle 6bcb570
Add run_curvature_stats
SylviaWhittle acf0c56
Fix test_angle_diff_signed
SylviaWhittle 7326fad
Add test_calculate_curvature_stats_image
SylviaWhittle 613b1cf
Disable defects functions and add linear version of angles_per_nm
SylviaWhittle a70a773
Fix plotting for updated curvature functions and remove defects funct…
SylviaWhittle 01f0fce
Disable plotting test
SylviaWhittle ec0dabd
Integrate curvature stats into processing.py
SylviaWhittle cfb9cf6
Add curvature config option: run
SylviaWhittle beb263d
Add 'pad_width' to disordered tracing output for later grain alignment
SylviaWhittle 8775c6e
Fix disordered tracing test given addition of 'pad_width'
SylviaWhittle 311a6c0
Add curvature config to tests
SylviaWhittle cfb9074
Fix curvature tests and disable all relating to defects
SylviaWhittle 76d60e4
Fix processing tests
SylviaWhittle b48bf08
[pre-commit.ci] Fixing issues with pre-commit
pre-commit-ci[bot] 016782a
Make curvature plotting functions part of the Images class
SylviaWhittle 1132050
Add whole image curvature plot and individual grain curvature plots f…
SylviaWhittle 011c0c6
Add plots and config to validation
SylviaWhittle 7ab8c91
Add test for plot_curvatures
SylviaWhittle d72d053
Add beginnings of curvature file
SylviaWhittle a963492
Add angle_diff_signed
SylviaWhittle 90e8722
Add test_angle_diff_signed
SylviaWhittle 9b15cb8
Add discrete_angle_difference_per_nm_circular
SylviaWhittle e702aea
Fix normalisation and flipped subtractions in first and last index
SylviaWhittle 307a89b
Add test for discrete_angle_difference_per_nm_circular
SylviaWhittle e2356ab
Add find_curvature_defects_simple_threshold
SylviaWhittle 2a76b75
Add test for find_curvature_defects_simple_threshold
SylviaWhittle 05f22d7
Add calculate_trace_distances_to_last_points_circular
SylviaWhittle c9af571
Add calculate_distances_between_distances_circular
SylviaWhittle 6dac959
Add test_trace_distances_to_last_points_circular
SylviaWhittle a71aeeb
Add test_calculate_distances_between_defects_circular
SylviaWhittle 533ba7b
Add calculate_number_of_defects
SylviaWhittle ccf0acd
add test_caclculate_number_of_defects
SylviaWhittle b559441
Add calculate_curvature_stats_single_grain_circular
SylviaWhittle 5525cd7
Add calculate_curvature_stats_image
SylviaWhittle ef895c5
Add plot_curvatures
SylviaWhittle f1fef84
Add plot_curvatures_individual_grains
SylviaWhittle 5b6bb88
Add test_plot_curvature
SylviaWhittle 378ca58
Add run_curvature_stats
SylviaWhittle 7f5f389
Fix test_angle_diff_signed
SylviaWhittle 0b1f0e1
Add test_calculate_curvature_stats_image
SylviaWhittle da3fff4
Disable defects functions and add linear version of angles_per_nm
SylviaWhittle 7757dbd
Fix plotting for updated curvature functions and remove defects funct…
SylviaWhittle a9a647e
Disable plotting test
SylviaWhittle 25e6847
Integrate curvature stats into processing.py
SylviaWhittle d4dc4c1
Add curvature config option: run
SylviaWhittle b982bde
Add 'pad_width' to disordered tracing output for later grain alignment
SylviaWhittle 767ee71
Fix disordered tracing test given addition of 'pad_width'
SylviaWhittle f44992f
Add curvature config to tests
SylviaWhittle 8b9e2b2
Fix curvature tests and disable all relating to defects
SylviaWhittle 0dd6823
[pre-commit.ci] Fixing issues with pre-commit
pre-commit-ci[bot] 3873a65
Make curvature plotting functions part of the Images class
SylviaWhittle 0ed667e
Add whole image curvature plot and individual grain curvature plots f…
SylviaWhittle 4d683aa
Add plots and config to validation
SylviaWhittle 84acd11
Add test for plot_curvatures
SylviaWhittle 0a78655
Fix: Formatting from rebase
SylviaWhittle a76b333
Fix tests: after rebase
SylviaWhittle 9daab07
Merge remote-tracking branch 'origin/SylviaWhittle/curvature' into Sy…
SylviaWhittle 3f42cae
[pre-commit.ci] Fixing issues with pre-commit
pre-commit-ci[bot] e4928b2
Merge main into curvature
SylviaWhittle e6ef86a
Remove: Add defect code
SylviaWhittle 6dbfad1
Fix: test_process_scan_both: topostats file needed updating to contai…
SylviaWhittle 1bd174d
Fix: test_calculate_curvature_stats_image: use absolute curvature values
SylviaWhittle 695ac3c
Merge main into curvature
SylviaWhittle 7d0bb3e
Fix: test_process_scan_both: Merge conflict
SylviaWhittle b368847
Add: test_process_scan_stages parametrisation for when curvature sta…
SylviaWhittle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6.86 KB
(100%)
tests/resources/process_scan_topostats_file_regtest.topostats
Binary file not shown.
Binary file modified
BIN
+18 Bytes
(100%)
tests/resources/tracing/disordered_tracing/catenanes_disordered_tracing_crop_data.pkl
Binary file not shown.
Binary file modified
BIN
+14 Bytes
(100%)
tests/resources/tracing/disordered_tracing/rep_int_disordered_tracing_crop_data.pkl
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should have a test that checks if the
Curvature
option isTrue
which would require all prior steps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this? (New commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b368847 checks everything upto
Splining
is disabled andCurvature
is disabled and others tests check that output of curvature are produced if enabled.