feature: Adds filter sub-command #1071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #741 Adds the "swiss-army knife" component to run just filtering on files. This involved modifying how the `.topostats` files are loaded and extracted because of the nesting (see #1068). Tests currently fail because the `tests/resources/test_image/minicircle_small.topostats` is version `0.1` and doesn't therefore work with the refactored structure (surprised #1068 passed all tests actualy!). A separate commit will be made for updating this test file and the associated tweaking of tests.
The `tests/resources/test_image/minicircle_small.topostats` was version `0.1` and failed the updates and tests that now work with `0.2`. I've therefore updated this test file and tweaked the associated tests to work with these files. All tests pass locally (watch them fail on CI!).
ns-rse
requested review from
llwiggins,
MaxGamill-Sheffield and
SylviaWhittle
|
I was 1/3 right, its only Windows where its failing in CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #741
Adds the "swiss-army knife" component to run just filtering on files so users can now run just the filtering step.
This involved modifying how the
.topostatsfiles are loaded and extracted because of the nesting (see #1068).The
tests/resources/test_image/minicircle_small.topostatswas version0.1and failed the updates and tests that nowwork with
0.2. I've therefore updated this test file and tweaked the associated tests to work with these files.All tests pass locally (watch them fail on CI!).
(These checks came in handy as it reminded me to add the new option to
docs/configuration.md😄 ).Before submitting a Pull Request please check the following.
docs/configuration.mddocs/usage.mddocs/data_dictionary.mddocs/advanced.mdand new pages it should link to.topostats/validation.pyto ensure entries are valid.topostats/entry_point.py.