Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make players die funnier #428

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Make players die funnier #428

merged 4 commits into from
Nov 14, 2024

Conversation

marchc1
Copy link
Member

@marchc1 marchc1 commented Sep 3, 2024

Players die with force when hit by bullets.

@TeeMeeFe
Copy link

TeeMeeFe commented Sep 3, 2024

Does this also affect NPC's?
Otherwise, i like this idea.

@marchc1
Copy link
Member Author

marchc1 commented Sep 3, 2024

Does this also affect NPC's?

If they're passed through any of the squishy functions yes (and I think they are)

@marchc1
Copy link
Member Author

marchc1 commented Sep 4, 2024

Does this also affect NPC's? Otherwise, i like this idea.

You edited after I made the comment but would you rather them not affect NPC's? Just want to make sure I understand what you're saying

@TeeMeeFe
Copy link

TeeMeeFe commented Sep 4, 2024

Does this also affect NPC's? Otherwise, i like this idea.

You edited after I made the comment but would you rather them not affect NPC's? Just want to make sure I understand what you're saying

No, i actually would like them to be affected as well. (I should have used "anyway" instead of otherwise)

@thecraftianman thecraftianman self-assigned this Oct 31, 2024
Copy link
Member

@thecraftianman thecraftianman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking 2 months to properly review this lol, I kept forgetting about it. Overall it's probably fine besides the couple of changes that I mentioned.

lua/acf/damage/damage_sv.lua Outdated Show resolved Hide resolved
lua/acf/damage/damage_sv.lua Outdated Show resolved Hide resolved
lua/acf/damage/overpressure_sv.lua Outdated Show resolved Hide resolved
lua/acf/damage/overpressure_sv.lua Outdated Show resolved Hide resolved
lua/acf/damage/damage_sv.lua Outdated Show resolved Hide resolved
@thecraftianman thecraftianman merged commit 9e33294 into ACF-Team:dev Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants