-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KAN readout options for MACE with possible better accuracy #655
base: develop
Are you sure you want to change the base?
Conversation
Nice work. A couple of questions and comments. Do you have mace results that you can share? The improvement in validation error for Allegro is impressive, but Allegro is generally less accurate than mace. So I'd like to see how the improvements translate. You should really have the y axis of your bar charts start at zero. This kinds of thing is in the first chapter of "How to Lie with Statistics" https://g.co/kgs/RGfduso |
@gabor1 Thanks for the quick feedback! |
Dear @Hongyu-yu, thank you very much for you PR and nice work. Just an extra note, I am very skeptical about KANs in general, I am bit surprised that it leads to any real improvement. So I would wait to see more results on MACE to merge that. |
@ilyes319 Thanks for the quick feedback! |
Thanks, how are the changes to torch.save related to KAN? |
torch.save directly not work for KAN with error
But works with |
… shows better performance
MACE + KAN
With additional KAN readout for MACE, more complex combination of spherical basis emerges with a more accurate MACE model and even makes MACE more explainable. Tests and benchmark results will be updated at https://arxiv.org/abs/2409.03430v1.
dill
is used for torch.save/loadpykan
is used for multikanUsage: add --KAN_readout in command line like
mace_run_train --KAN_readout ...
Hope this pull could provide a more accurate MACE model to the community!
If it helps and is used, please consider to cite
https://arxiv.org/abs/2409.03430v1
andhttp://arxiv.org/abs/2408.10205
.Hongyu Yu