Constant Linear Layer #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ConstLinearLayer to latest
|
This one is also usable now though it might not be written in the most elegant manner. @cortner @CheukHinHoJerry Any feedback from you would be much appreciated. |
Fix the linear dependence issue
|
A note : Ref: #17 (comment) |
cortner
requested changes
Oct 5, 2023
|
Ready to merge if all of us are happy. |
cortner
requested changes
Oct 5, 2023
src/ConstLinearLayer.jl
Outdated
| in_dim::Integer | ||
| out_dim::Integer | ||
| struct ConstLinearLayer <: AbstractExplicitLayer | ||
| op |
There was a problem hiding this comment.
this gives you a type instability. you still need to specify the type of the operator. Something like this:
struct ConstLinL{TOP}
op::TOP
end
|
Quick question: shall we merge this PR so that the consequential changes can be based on it? We can create an issue if there's still something to be improved in the ConstLinearLayer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symmetrisation layer (the BB layer) should be a Linear Layer with constant (frozen) parameters. (cf. #12)