Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Long tutorial #225

Open
wants to merge 127 commits into
base: v0.6.x
Choose a base branch
from
Open

WIP: Long tutorial #225

wants to merge 127 commits into from

Conversation

wcwitt
Copy link
Collaborator

@wcwitt wcwitt commented Aug 22, 2024

Long overdue to add my long tutorial from last year (https://github.com/wcwitt/ACEpotentials-Tutorial) to the documentation. For now I'm just starting the process ... trying to remember how the docs build works.

@wcwitt
Copy link
Collaborator Author

wcwitt commented Aug 22, 2024

Need to pause work on this until #227 is resolved.

@cortner
Copy link
Member

cortner commented Aug 22, 2024

I can help starting next week.

@cortner
Copy link
Member

cortner commented Aug 23, 2024

Should your tutorial from last year maybe be added to the v0.6 branch? And then we update it for the 0.8 branch within the next 1-2 weeks in parallel with retiring ACE1 and ACE1x and registering 0.8?

@wcwitt
Copy link
Collaborator Author

wcwitt commented Aug 23, 2024

Can do whatever you prefer. It was originally a notebook and I used an auto-converter to make it more Literate-like. My immediate goal is just to get it running in that form

@cortner
Copy link
Member

cortner commented Aug 26, 2024

I think it does not make sense adding this tutorial to 0.8-dev until ACE1 is removed from this branch and then the tutorial must be (minimally) updated anyhow. But ACE1 = 0.6 branch won't die immediately I think, so if you are keen to bring the tutorial into ACEpotentials in it's current form, then I think the 0.6 branch is the natural target.

Whether you want to invest that time I'm not sure - this is up to you obviously.

@wcwitt wcwitt changed the base branch from main to v0.6.x August 26, 2024 15:15
@wcwitt
Copy link
Collaborator Author

wcwitt commented Aug 26, 2024

I've changed the base branch for now.

@cortner
Copy link
Member

cortner commented Sep 9, 2024

What's the situation with this PR? Should we try to still fix this?

@wcwitt
Copy link
Collaborator Author

wcwitt commented Sep 9, 2024

We can act on this once there is a decision on v0.6 vs v0.8 for next week's tutorial.

@cortner
Copy link
Member

cortner commented Sep 9, 2024

Ok - hopefully tonight. I think Im very close

@cortner
Copy link
Member

cortner commented Oct 22, 2024

sorry we never merged this. Should this still go into the 0.6 branch?

@wcwitt
Copy link
Collaborator Author

wcwitt commented Oct 24, 2024

I'm inclined to close this and turn all our attention to 0.8. Okay?

@cortner
Copy link
Member

cortner commented Oct 24, 2024

Maybe I would make this depend on whether we can reproduce the pure2b setting in 0.8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants