Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain argument for site_descriptors #185

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Domain argument for site_descriptors #185

merged 2 commits into from
Nov 9, 2023

Conversation

cortner
Copy link
Member

@cortner cortner commented Nov 6, 2023

Related to this issue

@siasolt -- do you mind trying this out.

@cortner
Copy link
Member Author

cortner commented Nov 6, 2023

If it's not clear how to try this:

  • clone the ACEpotentials.jl repo
  • checkout the descriptors branch
  • In your project folder
    • activate the project
    • go to package manager ]
    • dev folder_to_ACEpotentials
  • restart all Julia instances in which you want to test this.

@siasolt
Copy link

siasolt commented Nov 8, 2023

This worked!

@cortner
Copy link
Member Author

cortner commented Nov 8, 2023

@wcwitt -- this is a tiny and trivial change to the current implementation. Can you take a brief glance and confirm whether or not you are happy for me to merge this?

@wcwitt
Copy link
Collaborator

wcwitt commented Nov 8, 2023

Fine with me, thanks. Hopefully my tweak will fix the CI (related: #183 (comment)).

@cortner cortner merged commit f39e4e8 into main Nov 9, 2023
4 checks passed
@cortner cortner deleted the descriptors branch November 9, 2023 00:41
@cortner
Copy link
Member Author

cortner commented Nov 9, 2023

registered as 0.6.4

@siasolt -- if you can now free ACEpotentials then put a version bound of 0.6.4 in your project and it should then update your manifest and packages automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants