forked from nih-sparc/sparc-api
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neuron search and switch to scicrunch _dev #19
Open
Tehsurfer
wants to merge
64
commits into
ABI-Software:main
Choose a base branch
from
Tehsurfer:scicrunch-doi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RTAL_AWS_SECRET cannot be found.
Indeed, there were various incompatibilities, especially after installing the `osparc` package.
Although only the staging site is useable, we will be using the official site at some point.
This requires some configuration information (as JSON), which is currently hard-coded.
Indeed, during our testing (`tests/test_osparc.py`), there have been cases where an exception was raised, but not by us, and with no argument...?!
Not sure why I originally wrote this "SedML"!
We were searching for "heart" hence our filtering for scaffolds was only returning 3 hits while it should return 14 hits if we want all the scaffolds.
If anything, one should create an environment variable for SCI_CRUNCH_HOST on their system.
…of a PMR workspace.
- Bug fix for some datasets not returning _any_ objects - Switch scicrunch-query-string from using the route to using URL params (this is now implemented in tehsurfer/map-side-bar)
… into Tehsurfer-mimetypes-used
… integrated-feature
Previously there was no check to make sure we made it to the end of our desired attributes. This has now been added along with some comments to explain what is going on
… into integrated-feature
dbrnz
pushed a commit
to dbrnz/sparc-api
that referenced
this pull request
Nov 21, 2021
uncommenting biolucida tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes viewable here:
https://jesses-sparc-science.herokuapp.com/maps
Type of change
Delete those that don't apply.
How Has This Been Tested?
Ran locally
Checklist: