Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tube mesh core sampling #263

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Improve tube mesh core sampling #263

merged 11 commits into from
Sep 12, 2024

Conversation

rchristie
Copy link
Member

No description provided.

oneway1225
oneway1225 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@oneway1225 oneway1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of my comments revolve around the change from using elements count across major to minor. It's not a major issue but I think it might benefit from more clarity.

src/scaffoldmaker/meshtypes/meshtype_3d_tubenetwork1.py Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_wholebody2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_wholebody2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/meshtypes/meshtype_3d_wholebody2.py Outdated Show resolved Hide resolved
src/scaffoldmaker/utils/tubenetworkmesh.py Show resolved Hide resolved
src/scaffoldmaker/utils/tubenetworkmesh.py Show resolved Hide resolved
src/scaffoldmaker/utils/tubenetworkmesh.py Outdated Show resolved Hide resolved
@rchristie rchristie merged commit 75f71d0 into ABI-Software:main Sep 12, 2024
3 checks passed
@rchristie rchristie deleted the sample-tube branch September 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oneway1225 oneway1225 oneway1225 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchristie @oneway1225