Improve UX when invalid drawing happens #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following cases will cause some UX issues:
ESC
will cancel a drawing, but the tool button will still be selected.Enter/Return
when a drawing is not completed. The drawing will be cancelled, but the tool button will still be selected.The reason is that we switched from using the built-in toolbar to using direct API calls. Some of the keyboard and mouse support no longer exist.