Empty listing Bug Fix and Other Pending Changes #144
Conversation
| /* | ||
| * Non-hierarchical-namespace account can not have a customer-provided-key(CPK). | ||
| * Fail initialization of filesystem if the configs are provided. CPK is of | ||
| * two types: GLOBAL_KEY, and ENCRYPTION_CONTEXT. | ||
| */ | ||
| if ((isEncryptionContextCPK(abfsConfiguration) || isGlobalKeyCPK( | ||
| abfsConfiguration)) | ||
| && !getIsNamespaceEnabled(new TracingContext(tracingContext))) { |
There was a problem hiding this comment.
Why are we removing the close() method call here ?
There was a problem hiding this comment.
We needed close because we were checking it after creating filesystem.
Now we are checking it before creating file system and failing, so no need to close.
There was a problem hiding this comment.
Since this is a significant change will trigger a CI.
We can wait for CI results before merging this.
| @@ -672,7 +674,7 @@ protected void assumeBlobServiceType() { | |||
| */ | |||
| protected void assertPathDns(Path path) { | |||
| String expectedDns = getAbfsServiceType() == AbfsServiceType.BLOB | |||
| ? ABFS_BLOB_DOMAIN_NAME : ABFS_DFS_DOMAIN_NAME; | |||
| ? ABFS_BLOB_DOMAIN_NAME : ABFS_DFS_DOMAIN_NAME;; | |||
| @@ -175,7 +175,7 @@ public static String getMaskedUrl(URL url) { | |||
|
|
|||
| public static URL changeUrlFromBlobToDfs(URL url) throws InvalidUriException { | |||
| try { | |||
| url = new URL(url.toString().replace(ABFS_BLOB_DOMAIN_NAME, ABFS_DFS_DOMAIN_NAME)); | |||
| url = new URL(url.toString().replaceFirst(ABFS_BLOB_DOMAIN_NAME, ABFS_DFS_DOMAIN_NAME)); | |||
There was a problem hiding this comment.
Is it possible to have more than one .blob. in the url ?
There was a problem hiding this comment.
Updated code as per the discussion offline
| @@ -184,13 +186,30 @@ public static URL changeUrlFromBlobToDfs(URL url) throws InvalidUriException { | |||
|
|
|||
| public static URL changeUrlFromDfsToBlob(URL url) throws InvalidUriException { | |||
| try { | |||
| url = new URL(url.toString().replace(ABFS_DFS_DOMAIN_NAME, ABFS_BLOB_DOMAIN_NAME)); | |||
| int startIndex = url.toString().indexOf("//") + 2; | |||
There was a problem hiding this comment.
These two can be moved inside replacedUrl(0 function only
| @@ -646,12 +646,10 @@ public AbfsRestOperation listPath(final String relativePath, final boolean recur | |||
| abfsUriQueryBuilder.addQuery(QUERY_PARAM_COMP, LIST); | |||
| abfsUriQueryBuilder.addQuery(QUERY_PARAM_INCLUDE, METADATA); | |||
| abfsUriQueryBuilder.addQuery(QUERY_PARAM_PREFIX, getDirectoryQueryParameter(relativePath)); | |||
| abfsUriQueryBuilder.addQuery(QUERY_PARAM_MARKER, continuation); | |||
There was a problem hiding this comment.
if (continuation != null) {
abfsUriQueryBuilder.addQuery(QUERY_PARAM_MARKER, continuation);
}
There was a problem hiding this comment.
This was a redundant check. Same check is already added in AbfsUriQueryBuilder.java
public void addQuery(final String name, final String value) {
if (value != null && !value.isEmpty()) {
this.parameters.put(name, value);
}
}
|
:::: AGGREGATED TEST RESULT :::: ============================================================
|
No description provided.