Remove atomic dir action in fileStatus and listStatus from store class #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0005ca9.
…ception from BlobRenaameHandler
lease arrayList a clone
#120 * change exception type; other review comments; * comments wip * sync checks review wip * reviews comments at higher level taken * atomic method abstraction to client * Permissions not to have public constructor * added javadocs small fix : sync should return fix + lease can be sync and async. test fix3 fix2 fix1 * javadocs
deserialization needs empty constructor concurrency control to get availableSize no manual json parsing in renameAtomicity
…BlobClient always. No casting required
|
:::: AGGREGATED TEST RESULT :::: ============================================================
|
anmolanmol1234
approved these changes
Jul 1, 2024
| try { | ||
| return objectMapper.writeValueAsString(renamePendingJsonFormat); | ||
| } catch (JsonProcessingException e) { | ||
| throw new AbfsDriverException(e); |
There was a problem hiding this comment.
nit: Is this new exception type needed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #117 to comment #117 (comment)