Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToPath: percent decode input URI #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ToPath: percent decode input URI #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/lsp/text/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package text
import (
"fmt"
"io"
"net/url"
"sort"
"strings"

Expand Down Expand Up @@ -127,6 +128,7 @@ func ToURI(filename string) protocol.DocumentURI {
// ToPath converts URI to filename.
func ToPath(uri protocol.DocumentURI) string {
filename, _ := CutPrefix(string(uri), "file://")
filename, _ = url.PathUnescape(filename)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you still need to CutPrefix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but I used this version with clangd I think, but I'm not sure about edge cases.

return filename
}

Expand Down