Support existingSecret for redis configuration #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vad1mo
requested changes
Apr 10, 2024
| @@ -321,6 +321,8 @@ scaling: | |||
| redis: | |||
| host: | |||
| password: | |||
| existingSecret: | |||
There was a problem hiding this comment.
Can you uncomment those two lines, as they are optional.
Also you can add a comment above explaining the purpose of those two entries.
| @@ -280,6 +280,8 @@ scaling: | |||
| redis: | |||
| host: | |||
| password: | |||
| existingSecret: | |||
There was a problem hiding this comment.
Can you uncomment those two lines, as they are optional.
Also you can add a comment above explaining the purpose of those two entries.
|
Is there any progress with this merger? This feature is highly appreciated. |
yes, see #81 (review) |
So @sebastiansterk are you able to set the commenting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces scaling.redis.existingSecret and scaling.redis.existingSecretKey to enable referencing an existing secret containing the Redis password. This aligns with the Bitnami Redis chart, allowing both to use the same secret.