fix: allow omitting the datacenter value when creating a primary IP

83hd4d · Aug 7, 2023 · 2e8f6f1 · 2e8f6f1
1 parent 4399750
commit 2e8f6f1
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/hcloud/primary_ips/client.py b/hcloud/primary_ips/client.py
@@ -178,7 +178,8 @@ def get_by_name(self, name: str) -> BoundPrimaryIP | None:
     def create(
         self,
         type: str,
-        datacenter: Datacenter | BoundDatacenter,
+        # TODO: Make the datacenter argument optional
+        datacenter: Datacenter | BoundDatacenter | None,
         name: str,
         assignee_type: str | None = "server",
         assignee_id: int | None = None,
@@ -203,12 +204,12 @@ def create(
             "type": type,
             "assignee_type": assignee_type,
             "auto_delete": auto_delete,
-            "datacenter": datacenter.id_or_name,
             "name": name,
         }
-        if assignee_id:
+        if datacenter is not None:
+            data["datacenter"] = datacenter.id_or_name
+        if assignee_id is not None:
             data["assignee_id"] = assignee_id
-            data.pop("datacenter")
         if labels is not None:
             data["labels"] = labels