Entfernt Notwendigkeit für Default Condition #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblen45
requested changes
Aug 19, 2024
| @@ -159,6 +159,7 @@ export default { | |||
| } | |||
| }, | |||
| checkCondition(condition) { | |||
| if (condition == '') return true; | |||
There was a problem hiding this comment.
Ist das hier immer empty string oder kann es auch null oder undefined sein?
There was a problem hiding this comment.
Das ist halt ein string input Feld. An der Stelle ist die Condition immer ein String. Wenn man natürlich sowas wie 'null' oder 'undefined' als string bei der Condition angibt könnte es beim auswerten Probleme geben aber an der Stelle erstmal nicht.
process-engine-ci
added a commit
that referenced
this pull request
Aug 21, 2024
# Changelog v1.0.22 (2024-08-21) This changelog covers the changes between [v1.0.21 and v1.0.22](v1.0.21...v1.0.22). For further reference, please refer to the changelog of the previous version, [v1.0.21](https://github.com/5minds/node-red-dashboard-2-processcube-dynamic-form/releases/tag/v1.0.21). ## Merged Pull Requests - #5 Entfernt Notwendigkeit für Default Condition (merged 2024-08-21) - #6 Erlaubt benutzen von Default Values (merged 2024-08-20) ## Corresponding Issues - #4 `ui-dynamic-form` - `FormFields.defaultValue wird nicht berücksichtigt - #3 `ui-dynamic-form` - Condition sollte optional sein. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3