forked from bpmn-io/diagram-js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Bump to 15.2.4 #6
Draft
ElRaptorus
wants to merge
108
commits into
develop
Choose a base branch
from
feature/merge_from_origin
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to bpmn-io/bpmn-js#2187
This reverts the integration of the (partially broken) search into the popup menu.
Returning reference to viewbox can lead to undesired effects.
Using a local profile directory, this works on modern Linux, too: karma-runner/karma-firefox-launcher#183 (comment)
Requests to requestAnimationFrame may be dropped, depending on how the browser feels. If we want to reliably ensure work gets done, we have to setTimeout(work) things. Closes bpmn-io#921
Co-authored-by: Jarek Danielak <[email protected]>
This gives longer matches precedence. chore(search): penalize unmatched tokens This ensures we score "most relevant" results higher.
We'll otherwise break embedding with existing applications, cf. bpmn-io/bpmn-js-examples#302.
Ensure we update focus related behaviors consistently on manual and DOM triggered interactions.
If canvas for whatever reason is not focused, then movement does not happen. Related to bpmn-io#662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Siehe Changelog: https://github.com/bpmn-io/diagram-js/blob/develop/CHANGELOG.md
15.2.4
FIX
: canvasautoFocus
must explicitly be enabled (#956)FIX
: properly integratezoomscroll
with canvas focus (#956)FIX
: properly integratemovecanvas
with canvas focus (#956)15.2.3
FIX
: adjust search to prioritize start of word and exact matches (#953)FIX
: ignore whitespace when searching (#954)15.2.2
FIX
: correctKeyboard#bind
and config types (#948)15.2.1
FIX
: limit overly permissive regex (#949)15.2.0
FIX
: clear selection when opening search pad (#947)FIX
: correct dangling selection after search pad interaction (#947)CHORE
: simplify search pad pre-selection behavior (#947)15.1.0
FEAT
: integratepopup-menu
withsearch
(#932)FEAT
: recognize modernsearch
tokens insearch-pad
(#932)FEAT
: improvesearch
types (#932)FIX
: correctly handle duplicate entries and whitespace insearch
(#932)FIX
: findsearch
terms across all keys (#932)FIX
:search
always returns tokens for matched items (#932)15.0.0
FEAT
: make canvas browser selectable (#659)FEAT
: make keyboard binding implicit (#661)FEAT
: make multi-selection outline an outline concern (#944)Breaking Changes
Keyboard
binding target can no longer be chosen. Configure keyboard binding via thekeyboard.bind
configuration and rely on keybindings to work if the canvas has browser focus. (#661)Canvas
is now a focusable component, that is recognized accordingly by the browser, with all benefits for UX and interaction. Components that pull focus from theCanvas
during modeling must ensure to restore the focus (if intended), viaCanvas#restoreFocus
. (#661)selection
feature does not provide visual outline by default anymore. Use theoutline
feature to re-enable it. (#944)14.11.3
CHORE
: simplify viewbox cloning (#935)14.11.2
FIX
: restore search result highlight (#931)FIX
: correct search result highlight not being removed (#931)FIX
: do not change zoom when search openes (#931)14.11.1
Partially reverts v14.11.0.
FIX
: revertsearch
integration into popup menu14.11.0
FEAT
: addsearch
utilityFEAT
: sort popup entry search results semantically (#916)14.10.0
FEAT
: align search styling with other popups (#913)CHORE
: use existing outline in search (#913)FIX
: only commit search viewport changes onENTER
(#913)14.9.0
CHORE
: export types compatible withverbatimModuleSyntax
(#927, #864)CHORE
: re-compute context pad position next frame (#920)