fix: Always sync submodules before updating them #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the origin in `.git/config` matches the one in `.gitmodules`. Git will quite appropriately refrain from doing this automatically, because it never allows remote repositories to update local config. You have to ask. (See: https://stackoverflow.com/a/45679261) In Vundle's case, it is always correct to sync. These aren't repos that a developer maintains; they are effectively read-only copies of remote state. Since syncing is always correct, and git won't sync unless we ask, then we should always sync. Fixes VundleVim#911.
5HT2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the origin in
.git/configmatches the one in.gitmodules. Git will quite appropriately refrain from doing this automatically, because it never allows remote repositories to update local config. You have to ask.(See: https://stackoverflow.com/a/45679261)
In Vundle's case, it is always correct to sync. These aren't repos that a developer maintains; they are effectively read-only copies of remote state. Since syncing is always correct, and git won't sync unless we ask, then we should always sync.
Fixes VundleVim#911.
Authored by @chiphogg, here: VundleVim#912.