Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tile map loading for collision mask objects #4916

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Conversation

D8H
Copy link
Collaborator

@D8H D8H commented Feb 10, 2023

Fixes #4900

The issue was introduced by

Reproduce steps:

  • Open the platformer-with-tilemap example
  • Remove all the instance from the scene
  • First, add a collision mask object instance to the scene
  • Then, add a tile map object instance to the scene
  • Save the project.
  • Close GDevelop
  • Open back GDevelop

Expected:

  • The 2 instances show the map.

Actual:

  • The 2 instances show a placeholder.

tilesetJsonFile
)
: null;
const tileMap = TilemapHelper.TileMapManager.identify(tileMapJsonData);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix, the other changes is just to clean the code a bit.

This method was not adapted when the LDTK handling was added and the Tiled data was returned instead of a tuple.

@D8H D8H marked this pull request as ready for review February 10, 2023 14:12
@D8H D8H requested a review from 4ian as a code owner February 10, 2023 14:12
@D8H D8H merged commit a73a92d into master Feb 10, 2023
@D8H D8H deleted the fix-tilemap-loading branch February 10, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TileMapMask doesn't work with Tiled (1.9.2) exports
2 participants