Skip to content

0.1.0: Merge pull request #1 from 4dn-dcic/core2

Latest
Latest
Compare
Choose a tag to compare
@SooLee SooLee released this 30 Nov 22:05
· 1740 commits to master since this release
0.1.0
88f8dc2
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Further refactoring to use foursight-core more efficiently

  • Most of the classes are no longer inherited by foursight-cgap, but used by foursight-core internally by passing on init parameters like foursight_prefix etc. Only app_utils::AppUtils is inherited.
    • I'm planning to also remove inheritance of app_utils::AppUtils and move all tests to foursight-core soon.
  • The html template is no longer duplicated in foursight-cgap but the main title can be passed as parameter (currently set as a class variable in app_utils::AppUtils)
  • chalicelib/checks/helpers/confcheck.py should be imported by all checks (instead of importing decorator and CheckResult/ActionResult functions individually)
  • Dependency structure inside foursight-core is a little simpler now.
Assets 2
Loading