Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Navbar hover animation #15

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

yashksaini-coder
Copy link
Contributor

@yashksaini-coder yashksaini-coder commented Sep 29, 2024

Hi 👋🏼 @4darsh-Dev, After checking and configuring the codebase came up with the approach

  • Create a new branch so original source code is not affected.
  • To add a Navbar.css that includes css animation effects for the Navbar.
  • Kept it separate so as it does not affect other code and cause errors.
  • can be customized easily.

Here's what the changes look like:

navbar-enhance

configuring the right file path for the smart contracts compilation
Add new css for navbar animations such as Neon, underline

✅ Closes: 4darsh-Dev#10
Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
decentrade ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 7:03am

Copy link

deepsource-io bot commented Sep 29, 2024

Here's the code health analysis summary for commits fd86e2d..c739107. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 2 occurences introduced
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've succesfully made your Pull Request. It will be reviewed soon. Please have patience. Don't forget to star⭐ the Repo.

@yashksaini-coder
Copy link
Contributor Author

yashksaini-coder commented Sep 29, 2024

This PR fixes #10
Review the PR, and add labels wob24 & Level.

Copy link
Owner

@4darsh-Dev 4darsh-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,
Few changes are required adjust them..

frontend/src/components/Navbar.css Outdated Show resolved Hide resolved
frontend/src/components/Navbar.css Outdated Show resolved Hide resolved
@yashksaini-coder
Copy link
Contributor Author

@4darsh-Dev I have changes the font-size to the requested values, and pushed the changes to the navbar branch.

now the PR is ready to fix the #10 issue.

@4darsh-Dev 4darsh-Dev added wob24 winter of blockchain 24 level1 labels Sep 30, 2024
Copy link
Owner

@4darsh-Dev 4darsh-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,
seems fine

@4darsh-Dev 4darsh-Dev merged commit 580e73f into 4darsh-Dev:main Sep 30, 2024
7 of 8 checks passed
@yashksaini-coder yashksaini-coder deleted the navbar branch October 20, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants