Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 #535

Open
wants to merge 21 commits into
base: next
Choose a base branch
from
Open

v4 #535

wants to merge 21 commits into from

Conversation

franky47
Copy link
Member

Closes #425.

@coveralls
Copy link

coveralls commented Oct 27, 2022

Pull Request Test Coverage Report for Build 3337194975

Details

  • 16 of 23 (69.57%) changed or added relevant lines in 4 files are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 74.621%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/index.ts 11 14 78.57%
src/logger.ts 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
src/graceful-shutdown.ts 1 37.5%
src/logger.ts 6 61.11%
src/index.ts 14 65.93%
Totals Coverage Status
Change from base Build 1928007173: 0.03%
Covered Lines: 139
Relevant Lines: 182

💛 - Coveralls

BREAKING CHANGE: Fastify is now a peer-dependency.
BREAKING CHANGE: Removed deprecated options
Partially failed release 7.17.0 botched the lockfile.
By default, Sentry will use the `SENTRY_ENVIRONMENT`
environement variable to configure its environment
property. Since we required `NODE_ENV` to be always set,
this was overriding this default behaviour.

So now we only use `NODE_ENV` as a fallback if `SENTRY_ENVIRONMENT`
is not set.
- Replace Yarn with PNPM
- Add mkcert in CI/CD to generate test certificates
- Add `https` option to enable TLS
- Replace `delay` jig with built-in promisified `setTimeout`
Just in case someone tries to be smart and steal
a CI-bound root CA..
Merging of envs may need to be done at the module top-level
in consuming apps to be exposed to scripts
like database migrations.
Moreover, the server.env decoration can be overriden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4
2 participants