seonmiki 개포동배달음식, TODO, web(2), react 로그인 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonmiki
changed the title
Minkyu01
reviewed
Sep 13, 2024
| width: 500px; | ||
| height: 60px; | ||
| border-radius: 20px; | ||
| padding-left: 30px; |
There was a problem hiding this comment.
input에도 글자수 제한이 있으면 좋겠네요~!
padding : 0 30px;
| width: 50%; | ||
| height: 60vh; | ||
| border-radius: 20px; | ||
| overflow-y: scroll; |
There was a problem hiding this comment.
각 article에 스크롤 바가 생기는 것은 의도한 부분인가요?? 만약 그렇지 않다면 auto로 설정하면 내부 요소가 넘치진 않을 때 스크롤바를 없애고, 넘칠때만 스크롤바를 생성되게 할 수 있습니다!!
| } | ||
|
|
||
| p { | ||
| font-family: "Do Hyeon", sans-serif; |
There was a problem hiding this comment.
font-family도 body에서 font-family: "Inter", sans-serif, "Do Hyeon";을 먼전 선언한 다음해당 부분에서
font-family: "Do Hyeon"을 선언하면 font-family가 중복되는 것을 방지할 수 있습니다
| cursor: not-allowed; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
반응형 고려하실때 모바일 반응형은 적용이 안되있는거 같습니다... 시간 되실 때 해보시면 도움이 많이 되실 거예요!
Minkyu01
reviewed
Sep 13, 2024
| body { | ||
| line-height: 1; | ||
| } | ||
| /* ol, |
There was a problem hiding this comment.
헉 죄송합니다! 이전 파일 확인하면서 건드린 게 잘못 올라간 것 같습니다ㅠㅠ 수정해서 변경해두었습니다 확인해주셔서 감사합니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
까비 온보딩
제출합니다 :)