SGR: Check event var before allowing Hoenn Fossil resets #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check for the in-game event var that controls the Hoenn fossil revival state before allowing the mode to start. That prevents people from accidentally trying to start the mode before even giving a fossil to the scientist, or before the scientist is ready. It also makes sure the player remembered to save.
pekempy
approved these changes
Dec 16, 2024
hanzi
added a commit
to hanzi/pokebot-gen3
that referenced
this pull request
Dec 16, 2024
This applies the fix from 40Cakes#579 for Kanto Fossils as well
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a check for the in-game event var that controls the Hoenn fossil revival state before allowing the mode to start.
That prevents people from accidentally trying to start the mode before even giving a fossil to the scientist, or before the scientist is ready.
It also makes sure the player remembered to save.
Checklist
--line-length 120argument