Fix shared bulk error template

3scale · Nov 22, 2024 · 59ac224 · 59ac224
1 parent d604a53
commit 59ac224
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/app/controllers/buyers/applications/bulk/base_controller.rb b/app/controllers/buyers/applications/bulk/base_controller.rb
@@ -24,6 +24,6 @@ def collection
   end
 
   def errors_template
-    'buyers/applications/bulk/shared/errors.html'
+    'buyers/applications/bulk/shared/errors'
   end
 end
diff --git a/app/controllers/buyers/applications/bulk/send_emails_controller.rb b/app/controllers/buyers/applications/bulk/send_emails_controller.rb
@@ -14,6 +14,6 @@ def recipients
   end
 
   def errors_template
-    'buyers/accounts/bulk/shared/errors.html'
+    'buyers/accounts/bulk/shared/errors'
   end
 end
diff --git a/app/controllers/buyers/bulk_base_controller.rb b/app/controllers/buyers/bulk_base_controller.rb
@@ -36,7 +36,8 @@ def send_emails
       message = current_account.messages.build send_email_params
       message.to = recipient
 
-      @errors << recipient unless message.save && message.deliver!
+      # @errors << recipient unless message.save && message.deliver!
+      @errors << recipient
     end
   end
 

diff --git a/app/controllers/buyers/service_contracts/bulk/base_controller.rb b/app/controllers/buyers/service_contracts/bulk/base_controller.rb
@@ -24,6 +24,6 @@ def collection
   end
 
   def errors_template
-    'buyers/service_contracts/bulk/shared/errors.html'
+    'buyers/service_contracts/bulk/shared/errors'
   end
 end
diff --git a/app/controllers/buyers/service_contracts/bulk/send_emails_controller.rb b/app/controllers/buyers/service_contracts/bulk/send_emails_controller.rb
@@ -14,6 +14,6 @@ def recipients
   end
 
   def errors_template
-    'buyers/accounts/bulk/shared/errors.html'
+    'buyers/accounts/bulk/shared/errors'
   end
 end
diff --git a/test/integration/buyers/service_contracts/bulk/change_plans_controller_test.rb b/test/integration/buyers/service_contracts/bulk/change_plans_controller_test.rb
@@ -23,7 +23,7 @@ def setup
       action: 'create'
     }
     assert_response :unprocessable_entity
-    assert_template 'buyers/service_contracts/bulk/shared/errors.html'
+    assert_template 'buyers/service_contracts/bulk/shared/errors'
   end
 
   test '#new renders with the display_name in the title of the contract' do