THREESCALE-9976 Fix GRPC

[eguzki]

What

Fixes https://issues.redhat.com/browse/THREESCALE-9976

GRPC leverages the POST HTTP2 method (GRPC Spec) . APIcast reads the body looking for request params for POST based requests using ngx.req.read_body. However, ngx.req.read_body does not support HTTP2 and it blocks the request. The clients receive connection timeout errors.

Added development environment for GRPC scenario

Verification steps

• Build docker image from this git branch

make runtime-image IMAGE_NAME=apicast-test

• Run grpc dev environment

cd dev-environments/grpc
make gateway-certs
make upstream-certs
make gateway IMAGE_NAME=apicast-test

• Download GRPC client

make grpcurl

• Run request to echo endpoint

bin/grpcurl -vv -insecure -H "app_id: abc123" -H "app_key: abc123" -authority gateway.example.com 127.0.0.1:8443 main.HelloWorld/Greeting

The command should return the echo response

Resolved method descriptor:
rpc Greeting ( .main.GreetingMessage ) returns ( .main.GreetingReply );

Request metadata to send:
app_id: abc123
app_key: abc123

Response headers received:
content-type: application/grpc
date: Fri, 03 Nov 2023 11:41:16 GMT
server: openresty

Estimated response size: 32 bytes

Response contents:
{
  "hostname": "d7728ab86df0",
  "clientAddress": "172.19.0.3:53564"
}

Response trailers received:
(empty)
Sent 0 requests and received 1 response

[tkan145]

Not sure why GH print the review twice 😕

[tkan145]

It's just a small thing but I think this is an unrelated change?

[eguzki]

It's just the IDE tool removing trailing spaces

[tkan145]

Same as above

[eguzki]

It's just the IDE tool removing trailing spaces

[tkan145]

However, ngx.req.read_body does not support HTTP2 and it blocks the request.

Do you mean ngx.req.get_post_args? As the line client request body saved to a temporary file can be seen from the log, so I think ngx.req.read_body works with http2

Ignore my previous comment. just found this one openresty/lua-nginx-module#2172

[eguzki]

However, ngx.req.read_body does not support HTTP2 and it blocks the request.

Do you mean ngx.req.get_post_args? As the line client request body saved to a temporary file can be seen from the log, so I think ngx.req.read_body works with http2

Ignore my previous comment. just found this one openresty/lua-nginx-module#2172

From https://github.com/openresty/lua-nginx-module#ngxreqread_body

Due to the stream processing feature of HTTP/2 or HTTP/3, this api could potentially block the entire request. Therefore, this api is effective only when HTTP/2 or HTTP/3 requests send content-length header. For requests with versions lower than HTTP/2, this api can still be used without any problems.