Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended api tests #162

Merged
merged 5 commits into from
Dec 13, 2024
Merged

extended api tests #162

merged 5 commits into from
Dec 13, 2024

Conversation

Gituser010
Copy link
Contributor

GET /admin/api/application_plans

tests/integration/conftest.py Show resolved Hide resolved
threescale_api/resources.py Show resolved Hide resolved
@Gituser010 Gituser010 changed the title add get all applications plans test add get all applications plans test + add post activedocs test Oct 8, 2024
@Gituser010 Gituser010 changed the title add get all applications plans test + add post activedocs test finished admin/api/applications_plans; finished -||-/{-account_plans,active_docs}/{id} Oct 14, 2024
@Gituser010 Gituser010 changed the title finished admin/api/applications_plans; finished -||-/{-account_plans,active_docs}/{id} finished admin/api/applications_plans; finished -||-/{account_plans,active_docs}/{id} Oct 14, 2024
Copy link
Collaborator

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all changes do pipenv run python -m pylint tests/integration/conftest.py tests/integration/test_integration_account_plans.py tests/integration/test_integration_accounts.py tests/integration/test_integration_activedocs.py tests/integration/test_integration_application_plan.py threescale_api/client.py threescale_api/resources.py --disable="C0115,C0116" and fix lines where you did changes. Do the same for flake8.

tests/integration/test_integration_accounts.py Outdated Show resolved Hide resolved
tests/integration/test_integration_activedocs.py Outdated Show resolved Hide resolved
tests/integration/test_integration_activedocs.py Outdated Show resolved Hide resolved
tests/integration/test_integration_account_plans.py Outdated Show resolved Hide resolved
tests/integration/test_integration_account_plans.py Outdated Show resolved Hide resolved
GET /admin/api/application_plans
@Gituser010 Gituser010 changed the title finished admin/api/applications_plans; finished -||-/{account_plans,active_docs}/{id} extended api tests Oct 15, 2024
@Gituser010 Gituser010 force-pushed the master branch 3 times, most recently from 1c6564a to 218bf6b Compare October 22, 2024 11:34
@Gituser010 Gituser010 requested a review from mkudlej October 22, 2024 11:36
Copy link
Collaborator

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me OK except of some small problems, please fix them.

tests/integration/conftest.py Outdated Show resolved Hide resolved
tests/integration/test_integration_accounts.py Outdated Show resolved Hide resolved
tests/integration/test_integration_backend_usages.py Outdated Show resolved Hide resolved
tests/integration/test_integration_backend_usages.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mkudlej mkudlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkudlej mkudlej requested a review from dhlavac December 13, 2024 06:52
@mkudlej mkudlej merged commit 443fabb into 3scale-qe:master Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants