-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended api tests #162
extended api tests #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for all changes do pipenv run python -m pylint tests/integration/conftest.py tests/integration/test_integration_account_plans.py tests/integration/test_integration_accounts.py tests/integration/test_integration_activedocs.py tests/integration/test_integration_application_plan.py threescale_api/client.py threescale_api/resources.py --disable="C0115,C0116"
and fix lines where you did changes. Do the same for flake8.
GET /admin/api/application_plans
1c6564a
to
218bf6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me OK except of some small problems, please fix them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GET /admin/api/application_plans