Remove python 3.11 dependencies #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usually for ENV variables nonempty (except "false", "no" or "0") are treated as truthful. |
|
I would create a new function for conversion, something like: def str2bool(v: str) -> bool:
return str(v).lower() in ("yes", "true", "t", "1", "on") |
dhlavac
previously approved these changes
May 21, 2024
mdujava
previously approved these changes
May 21, 2024
mdujava
approved these changes
May 21, 2024
|
FYI. workflows https://github.com/3scale-qe/3scale-api-python/tree/master/.github/workflows should be changed and tested with are locked to Python 3.11 and I think they should be checked with newer Python before this PR is merged. |
mkudlej
requested changes
May 21, 2024
|
As I remember we do not want to upgrade to 3.12 yet, this code works for 3.11 and 3.12, so should be fine to merge as is. |
dhlavac
approved these changes
May 23, 2024
|
@mkudlej can we merge it ? Tried with 3.11 and 3.12 should be working with both versions and image will be created with 3.11 |
mkudlej
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strbool is deprecated in new version of python.