Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never force path during evaluation phase #24

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Never force path during evaluation phase #24

merged 3 commits into from
Sep 27, 2024

Conversation

kokobd
Copy link
Contributor

@kokobd kokobd commented Sep 2, 2024

builtins.baseNameOf and builtins.pathExists requires the derivation that provides path in its output to be built during evaluation phase. We have a x86_64-linux Hydra server with a MacOS machine as a remote builder. We evaluate all derivations on the main Hydra server, only distributing the actual building to MacOS. builtins.pathExists caused the entire build process of MacOS derivations to run during evaluation. Those heavy work won't show as normal Hydra jobs, and the failures are shown in "Evaluation Error" tab.

Copy link
Owner

@3noch 3noch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I'd been meaning to fix this but never had the immediate need. Thank you.

@JackKelly-Bellroy
Copy link

Thanks for the approval. What can we do to help move this along?

@3noch 3noch merged commit 7f61fe9 into 3noch:main Sep 27, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants