Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable local_node-private e2e tests #63

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions cd/manager/jobs/e2e.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ type e2eTestJob struct {
const (
e2eTest_PrivatePublic string = "private-public"
e2eTest_LocalClientPublic string = "local_client-public"
e2eTest_LocalNodePrivate string = "local_node-private"
)

// Allow up to 4 hours for E2E tests to run
Expand Down Expand Up @@ -88,7 +87,7 @@ func (e e2eTestJob) startAllTests() error {
} else if err = e.startTests(e2eTest_LocalClientPublic); err != nil {
return err
} else {
return e.startTests(e2eTest_LocalNodePrivate)
return nil
}
}

Expand Down Expand Up @@ -118,9 +117,7 @@ func (e e2eTestJob) checkAllTests(expectedToBeRunning bool) (bool, error) {
return false, err
} else if localClientPublicStatus, err := e.checkTests(e.state.Params[e2eTest_LocalClientPublic].(string), expectedToBeRunning); err != nil {
return false, err
} else if localNodePrivateStatus, err := e.checkTests(e.state.Params[e2eTest_LocalNodePrivate].(string), expectedToBeRunning); err != nil {
return false, err
} else if privatePublicStatus && localClientPublicStatus && localNodePrivateStatus {
} else if privatePublicStatus && localClientPublicStatus {
return true, nil
}
return false, nil
Expand Down
Loading