llvm/CMakeLists: Manually-specified variables were not used by the pr… #5
Conversation
…oject. The following variables were set in CMakeLists, however, they were not used by the LLVM project build: LLVM_USE_CRT_DEBUG LLVM_USE_CRT_RELEASE
|
Unable to locate .performanceTestingBot config file |
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
|
Processing PR updates... |
|
Thanks @2lambda123 for opening this PR! For COLLABORATOR only :
|
![gitginie[bot]](https://avatars.githubusercontent.com/in/712912?s=60&v=4){kind=small}
There was a problem hiding this comment.
@2lambda123
Thank you for your contribution to this repository! We appreciate your effort in opening pull request.
Happy coding!
Their most recently public accepted PR is: #3 |
labels-and-badges
bot
added
bug
|
Important Review skippedAuto reviews are limited to specific labels. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
PR Details of @2lambda123 in avast-retdec :
|
Reviewer's Guide by SourceryThis pull request removes the unused variables File-Level Changes
Tips
|
There was a problem hiding this comment.
@2lambda123
Thank you for your contribution to this repository! We appreciate your effort in closing pull request.
Happy coding!
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @2lambda123 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
PR summaryThis Pull Request addresses an issue in the LLVM project's CMake configuration where the variables SuggestionConsider verifying if there are any other unused or redundant variables in the CMake configuration that could be cleaned up in a similar manner. Additionally, ensure that the removal of these variables does not affect any downstream projects or build scripts that might rely on them. Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect. Current plan usage: 7.13% Have feedback or need help? |
…oject.
The following variables were set in CMakeLists, however, they were not used by the LLVM project build:
LLVM_USE_CRT_DEBUG
LLVM_USE_CRT_RELEASE
Description
Related Issue
Types of changes
Checklist:
Summary by Sourcery
Remove unused CMake variables from the LLVM project build configuration to clean up the build script.
Bug Fixes: