Make it easy to subclass Saml2Controller #90
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtend the Saml2Controller, without needing to redefine all the routes. See aacotroneo/laravel-saml2@34fe227 for the original config that this is directly copying from
|
+1 I also bumped into this trying to add |
breart
reviewed
Sep 13, 2024
| | it used in the routes definition. | ||
| | | ||
| */ | ||
| 'saml2_controller' => '', |
There was a problem hiding this comment.
Why not define the default one here?
There was a problem hiding this comment.
I went with the empty string so as to mirror the original PR as closely as possible
aacotroneo/laravel-saml2@34fe227
I imagine the original author probably chose to do this so that user error would be marginally safer (that is to say, if they set their config to false or something it shouldn't break the routes).
|
I'm looking forward to this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a feature in the aacotroneo/laravel-saml2 library which allows users to extend the controller without having to redefine all the routes by defining a
saml2_controllerconfig value, which you can see here.It's very simple to implement, and I was able to duplicate the functionality with minimal tweaks to rectify stylistic differences between the two repos. My intent here is to make it easier for users of the aacotroneo lib to switch over to this one (and by users I mean me, specifically, but I'm sure other people could also use this feature).