Add safety check before trying to delete an SSH fingerprint

23technologies · Sep 20, 2021 · 7c40a46 · 7c40a46
1 parent f5b9ce4
commit 7c40a46
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/pkg/controller/infrastructure/ensurer/ssh_public_key.go b/pkg/controller/infrastructure/ensurer/ssh_public_key.go
@@ -69,13 +69,15 @@ func EnsureSSHPublicKey(ctx context.Context, client *hcloud.Client, publicKey []
 // client      *hcloud.Client   HCloud client
 // fingerprint string           SSH fingerprint
 func EnsureSSHPublicKeyDeleted(ctx context.Context, client *hcloud.Client, fingerprint string) error {
-	sshKey, _, err := client.SSHKey.GetByFingerprint(ctx, fingerprint)
-	if nil != err {
-		return err
-	} else if sshKey != nil {
-		_, err := client.SSHKey.Delete(ctx, sshKey)
+	if "" != fingerprint {
+		sshKey, _, err := client.SSHKey.GetByFingerprint(ctx, fingerprint)
 		if nil != err {
 			return err
+		} else if sshKey != nil {
+			_, err := client.SSHKey.Delete(ctx, sshKey)
+			if nil != err {
+				return err
+			}
 		}
 	}