fix: HttpService Injection in WebsocketService for Push Notification …

…Sending (#37) * fix: Fix HttpService injection in WebsocketService constructor to resolve undefined error * test: Fix websocketTestModule added HttpModule into imports
2060-io · Nov 13, 2024 · 52992d4 · 52992d4
1 parent bf2a6d5
commit 52992d4
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/packages/server/src/websocket/websocket.gateway.ts b/packages/server/src/websocket/websocket.gateway.ts
@@ -68,7 +68,7 @@ export class WebsocketGateway implements OnModuleInit, OnModuleDestroy {
         result: 'error',
         id: 1,
       })
-      this.logger.error(`WebSocket server listening on port ${WS_PORT}`)
+      this.logger.log(`WebSocket server listening on port ${WS_PORT}`)
     } catch (error) {
       this.logger.error('Error during WebSocket server initialization', error.stack)
       throw error

diff --git a/packages/server/src/websocket/websocket.module.ts b/packages/server/src/websocket/websocket.module.ts
@@ -5,13 +5,15 @@ import { MongooseModule } from '@nestjs/mongoose'
 import { StoreQueuedMessageSchema, StoreQueuedMessage } from './schemas/StoreQueuedMessage'
 import { StoreLiveSessionSchema, StoreLiveSession } from './schemas/StoreLiveSession'
 import { MessagePersister } from './services/MessagePersister'
+import { HttpModule } from '@nestjs/axios'
 
 @Module({
   imports: [
     MongooseModule.forFeature([
       { name: StoreQueuedMessage.name, schema: StoreQueuedMessageSchema },
       { name: StoreLiveSession.name, schema: StoreLiveSessionSchema },
     ]),
+    HttpModule,
   ],
   providers: [WebsocketGateway, WebsocketService, MessagePersister],
 })

diff --git a/packages/server/src/websocket/websocket.service.ts b/packages/server/src/websocket/websocket.service.ts
@@ -24,7 +24,6 @@ import { JsonRpcResponseSubscriber } from './interfaces/interfaces'
 @Injectable()
 export class WebsocketService {
   private readonly logger: Logger
-  private readonly httpService: HttpService
   private readonly redisSubscriber: Redis
   private readonly redisPublisher: Redis
   private server: Server
@@ -33,6 +32,7 @@ export class WebsocketService {
     @InjectModel(StoreQueuedMessage.name) private queuedMessage: Model<StoreQueuedMessage>,
     @InjectRedis() private readonly redis: Redis,
     private configService: ConfigService,
+    private readonly httpService: HttpService,
   ) {
     this.logger = new Logger(WebsocketService.name)
     this.redisSubscriber = this.redis.duplicate()
@@ -452,6 +452,19 @@ export class WebsocketService {
       // Retrieves the push notification URL from the configuration service
       const pushNotificationUrl = this.configService.get<string>('appConfig.pushNotificationUrl')
 
+      if (!pushNotificationUrl) {
+        this.logger?.error('[sendPushNotification] Push notification URL is not defined in appConfig')
+        return false
+      }
+
+      this.logger?.debug(`[sendPushNotification] pushNotificationUrl: ${pushNotificationUrl}`)
+      if (!token || !messageId) {
+        this.logger?.error('[sendPushNotification] Invalid token or messageId')
+        return false
+      }
+
+      this.logger?.debug(`[sendPushNotification] token: ${token} --- messageId: ${messageId}`)
+
       // Sends the push notification via HTTP POST request
       const response = await lastValueFrom(
         this.httpService.post(pushNotificationUrl, {

diff --git a/packages/server/test/WebsocketTestModule.ts b/packages/server/test/WebsocketTestModule.ts
@@ -4,13 +4,15 @@ import { WebsocketGateway } from '../src/websocket/websocket.gateway'
 import { MongooseModule } from '@nestjs/mongoose'
 import { StoreQueuedMessageSchema, StoreQueuedMessage } from '../src/websocket/schemas/StoreQueuedMessage'
 import { StoreLiveSessionSchema, StoreLiveSession } from '../src/websocket/schemas/StoreLiveSession'
+import { HttpModule } from '@nestjs/axios'
 
 @Module({
   imports: [
     MongooseModule.forFeature([
       { name: StoreQueuedMessage.name, schema: StoreQueuedMessageSchema },
       { name: StoreLiveSession.name, schema: StoreLiveSessionSchema },
     ]),
+    HttpModule,
   ],
   providers: [WebsocketGateway, WebsocketService],
 })