Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent default values for offer time fields when unnecessary #62

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

lotharking
Copy link
Contributor

@lotharking lotharking commented Dec 13, 2024

Summary

Changes

  • Updated the @Transform decorator to ensure offerExpirationTime and offerStartTime are not assigned default values. The transformation now checks the value's existence before parsing it with DateParser, avoiding unintended field inclusion.

Related Issues

Testing

Checklist

  • I have commented on my code, especially in areas that are hard to understand.
  • I have added only changes relevant to the issue in question.
  • I have added tests to confirm that my fix is effective or that my feature works as intended.
  • I have modified existing tests as needed to accommodate my changes.
  • I have flagged specific areas for further review, if necessary.
  • I have updated the documentation where necessary.

@lotharking lotharking changed the title fix/call offer optional values fix: Prevent default values for offer time fields when unnecessary Dec 13, 2024
@lotharking lotharking marked this pull request as ready for review December 13, 2024 03:47
@lotharking lotharking requested a review from genaris December 13, 2024 03:48
@genaris genaris merged commit 40f71a7 into main Dec 13, 2024
2 checks passed
@genaris genaris deleted the fix/call-offer-optional-values branch December 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants