fix: add maximumCredentialNumber

2060-io · Dec 18, 2024 · 25d4a97 · 25d4a97
1 parent 2f3d0e0
commit 25d4a97
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/packages/main/src/controllers/credentials/CreateRevocationRegistryDto.ts b/packages/main/src/controllers/credentials/CreateRevocationRegistryDto.ts
@@ -1,12 +1,22 @@
 import { ApiProperty } from '@nestjs/swagger'
-import { IsString, IsNotEmpty } from 'class-validator'
+import { IsString, IsNotEmpty, IsNumber } from 'class-validator'
 
 export class CreateRevocationRegistryDto {
   @ApiProperty({
     description: 'credentialDefinitionId',
-    example: 'did:web',
+    example:
+      'did:web:chatbot-demo.dev.2060.io?service=anoncreds&relativeRef=/credDef/8TsGLaSPVKPVMXK8APzBRcXZryxutvQuZnnTcDmbqd9p',
   })
   @IsString()
   @IsNotEmpty()
   credentialDefinitionId!: string
+
+  @ApiProperty({
+    description: 'maximumCredentialNumber',
+    default: 1000,
+    example: 1000,
+  })
+  @IsNumber()
+  @IsNotEmpty()
+  maximumCredentialNumber: number = 1000
 }
diff --git a/packages/main/src/controllers/credentials/CredentialTypeController.ts b/packages/main/src/controllers/credentials/CredentialTypeController.ts
@@ -419,7 +419,7 @@ export class CredentialTypesController {
    * @param credentialDefinitionId
    * @returns RevocationTypeInfo
    */
-  @Post('/revocationDefinition')
+  @Post('/revocationRegistry')
   public async createRevocationRegistry(@Body() options: CreateRevocationRegistryDto): Promise<string> {
     try {
       const agent = await this.agentService.getAgent()
@@ -436,7 +436,7 @@ export class CredentialTypesController {
         revocationRegistryDefinition: {
           credentialDefinitionId,
           tag: 'default',
-          maximumCredentialNumber: 1000,
+          maximumCredentialNumber: options.maximumCredentialNumber,
           issuerId: cred.credentialDefinition.issuerId,
         },
         options: {},
@@ -498,7 +498,7 @@ export class CredentialTypesController {
    *
    * @returns string[] with revocationRegistryDefinitionIds
    */
-  @Get('/revocationDefinition')
+  @Get('/revocationRegistry')
   public async getRevocationDefinitions(@Body() options: CreateRevocationRegistryDto): Promise<string[]> {
     const agent = await this.agentService.getAgent()
 

diff --git a/packages/model/src/types.ts b/packages/model/src/types.ts
@@ -47,6 +47,11 @@ export interface CredentialTypeInfo extends CreateCredentialTypeOptions {
   id: string
 }
 
+export interface RevocationRegistry {
+  credentialDefinitionId: string
+  maximumCredentialNumber: number
+}
+
 export interface CreatePresentationRequestOptions {
   requestedCredentials: RequestedCredential[]
 }