Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 111 commits into
base: feedback
Choose a base branch
from
Open

Feedback #1

wants to merge 111 commits into from

Conversation

github-classroom[bot]
Copy link

@github-classroom github-classroom bot commented Feb 14, 2022

👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to main since the assignment started. Your teacher can see this too.

Notes for teachers Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.
@AdnanA2 @HungryManSteve @DeJuanSpencer

github-classroom bot and others added 30 commits February 14, 2022 18:16
…o create the pojos we'll need but it basically works right now.
…o create the pojos we'll need but it basically works right now.
…o create the pojos we'll need but it basically works right now.
…ot change anything there in this commit. I have that saved in a different file.
… names match the same name as the respective file names.
…and thymeleaf. It works as expected. Just need to change populator values. Will mention changes requested on the google drive page but also will discuss when we meet again.
@RickieCanCodeIT
Copy link

Current Grade 🟢

Good job! I did find a few issues, but none grave enough to fail you. I notice your add hashtag submit and add review submit are the same button and it adds both a review and a hashtag even if you only tried to add one. Just so you know, you aren't limited to 1 form per page, you can have many forms per page, if you had just done 2, 1 for hashtag and 1 for review you could have had them separate, and honestly it probably would have worked out easier while working on your controller. You definitely should have tried styling a little bit better, you use dark hues in most places so at times it can be hard to read, and also there's a few places where your styling isn't consistent. Also you should absolutely style your lists, your hashtag pages are just unstyled lists (they function, but they don't look great). Your pictures I can see you made yourself, but if I'm being honest you probably could have made them look a bit cleaner. So this is a pass, but you really should work on your css styling skills.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants