Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various summoning fixes #575

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Various summoning fixes #575

merged 2 commits into from
Jan 14, 2025

Conversation

Ilwyd
Copy link
Contributor

@Ilwyd Ilwyd commented Jan 5, 2025 •
edited
Loading

What has been done?

  • Fixed an issue where players were unable to trade in their blood drain scrolls. (Also KTLint ran automatically on the file, actual fix is on line 330)
  • Enabled summoning in the experience lamp interface

Has your code been documented?

Yes

@Ilwyd Ilwyd requested a review from a team as a code owner January 5, 2025 16:36
@Ilwyd Ilwyd requested a review from DesecratedTree January 5, 2025 16:36
@Ilwyd Ilwyd changed the title Fix not being able to swap blood drain scrolls Various summoning fixes Jan 5, 2025
HarleyGilpin
HarleyGilpin approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@HarleyGilpin HarleyGilpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for the contribution.

@HarleyGilpin HarleyGilpin merged commit 902952e into 2011Scape:main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarleyGilpin HarleyGilpin HarleyGilpin approved these changes

@DesecratedTree DesecratedTree Awaiting requested review from DesecratedTree DesecratedTree is a code owner automatically assigned from 2011Scape/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ilwyd @HarleyGilpin